[exporter/prometheusremotewrite] feat: prom rw exporter add support for rw2 #35888
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Juraj Michalek <[email protected]>
github-actions
bot
requested review from
Aneurysm9,
bertysentry,
dashpole and
rapphil
ArthurSens
reviewed
Oct 21, 2024
dashpole
reviewed
Oct 25, 2024
dashpole
reviewed
Oct 25, 2024
dashpole
reviewed
Oct 25, 2024
dashpole
reviewed
Oct 25, 2024
dashpole
reviewed
Oct 25, 2024
dashpole
reviewed
Oct 25, 2024
dashpole
reviewed
Oct 25, 2024
dashpole
reviewed
Oct 25, 2024
dashpole
reviewed
Oct 25, 2024
exporter/prometheusremotewriteexporter/generated_component_telemetry_test.go
Outdated
Show resolved
Hide resolved
dashpole
reviewed
Oct 25, 2024
exporter/prometheusremotewriteexporter/internal/metadata/generated_telemetry.go
Outdated
Show resolved
Hide resolved
dashpole
reviewed
Oct 25, 2024
exporter/prometheusremotewriteexporter/internal/metadata/generated_telemetry_test.go
Outdated
Show resolved
Hide resolved
jpkrohling
changed the title
Co-authored-by: Bartlomiej Plotka <[email protected]>
Co-authored-by: Bartlomiej Plotka <[email protected]>
Co-authored-by: Bartlomiej Plotka <[email protected]>
Co-authored-by: Bartlomiej Plotka <[email protected]>
Co-authored-by: Bartlomiej Plotka <[email protected]>
Co-authored-by: Bartlomiej Plotka <[email protected]>
Co-authored-by: Bartlomiej Plotka <[email protected]>
|
needs rebase :/ |
bwplotka
reviewed
Dec 3, 2024
| req.Header.Set("Content-Type", "application/x-protobuf;proto=io.prometheus.write.v2.Request") | ||
| req.Header.Set("X-Prometheus-Remote-Write-Version", "2.0.0") | ||
| default: | ||
| return errors.New("proto message validated earlier") |
There was a problem hiding this comment.
nit: if we do err check vs panic here, let's do it properly (it's true a later version of this code could by accident remove pre-validation.
Suggested change
| return errors.New("proto message validated earlier") | |
| return fmt.Errorf("unsupported remote-write protobuf message: %v (should be validated earlier)", prwe.RemoteWriteProtoMsg) |
bwplotka
reviewed
Dec 3, 2024
| ok := proto.Unmarshal(dest, wr) | ||
| require.NoError(t, ok) | ||
| assert.Len(t, wr.Timeseries, expected) | ||
| // TODO check labels |
There was a problem hiding this comment.
Should there be a GH issue about it to not forget? Or todo now?
bwplotka
reviewed
Dec 3, 2024
| buf.protobuf.Reset() | ||
| defer bufferPool.Put(buf) | ||
|
|
||
| // Uses proto.Marshal to convert the WriteRequest into bytes array |
There was a problem hiding this comment.
This comments repeats in multiple places. Is it really useful?
bwplotka
reviewed
Dec 3, 2024
|
|
||
| // Uses proto.Marshal to convert the WriteRequest into bytes array. | ||
| if errMarshal := buf.protobuf.Marshal(request); errMarshal != nil { | ||
| errs = multierr.Append(errs, consumererror.NewPermanent(errMarshal)) |
There was a problem hiding this comment.
ditto: risk of race here (errs shared by multiple goroutines and not locked)
bwplotka
reviewed
Dec 3, 2024
| } | ||
|
|
||
| // TODO implement batching | ||
| // TODO how do we handle symbolsTable with batching? |
There was a problem hiding this comment.
You have to build separate symbol tables or use a bigger single one, whatever is cheaper.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Draft PR for adding rw2 support in the prometheus remote write exporter.
Very much a draft, not full implementation of the spec with a lot of code duplication and no tests WIP.
TODO:
Link to tracking issue #33661
Fixes
Testing
Documentation